Skip to content

Update: simplify legacy storage and marketplace cache schemas#14

Merged
SI-RUI-ZHANG merged 3 commits intomainfrom
skillmgr-legacy-cleanup
Apr 15, 2026
Merged

Update: simplify legacy storage and marketplace cache schemas#14
SI-RUI-ZHANG merged 3 commits intomainfrom
skillmgr-legacy-cleanup

Conversation

@SI-RUI-ZHANG
Copy link
Copy Markdown
Contributor

原问题

  • App-owned storage path policy was split across store/shared_store.py, store/harness_support.py, and application/marketplace/cache.py, which left shared-store migration rules and marketplace cache rules inconsistent.
  • Marketplace internals still carried dead cache/schema fields (githubFolderUrl, snapshot repoUrl) and old cache namespaces even though the runtime no longer needed those payload shapes.
  • Docs and frontend tests had drifted from the current runtime contract, including stale managed-skills wording and repeated marketplace fixture payloads using old avatar semantics.

本次修复

  • Added skill_manager/storage_paths.py as the single app-owned path policy module, moved shared-store resolution and harness settings path ownership there, and switched marketplace cache resolution to canonical app data only.
  • Removed dead marketplace cache fields and snapshot metadata (githubFolderUrl, internal repo_url), bumped detail and repo-metadata cache namespaces to v2, and kept compatibility only for shared-store fallback plus Codex legacy discovery.
  • Realigned README, managed-skills copy, and frontend/backend test fixtures to the current DTO/runtime contract, including a shared marketplace frontend fixture helper and dedicated storage-path unit coverage.

改动文件
README.md
frontend/src/tests/App.test.tsx
frontend/src/features/marketplace/components/MarketplaceCard.test.tsx
frontend/src/features/marketplace/components/MarketplaceDetailView.test.tsx
frontend/src/features/marketplace/screens/MarketplacePage.loading.test.tsx
frontend/src/features/marketplace/screens/MarketplacePage.test.tsx
frontend/src/features/marketplace/test-fixtures.ts
frontend/src/features/skills/screens/ManagedSkillsPage.tsx
skill_manager/application/container.py
skill_manager/application/marketplace/cache.py
skill_manager/application/marketplace/catalog.py
skill_manager/application/marketplace/queries.py
skill_manager/application/marketplace/repo_snapshots.py
skill_manager/application/marketplace/resolver.py
skill_manager/application/read_model_service.py
skill_manager/harness/resolution.py
skill_manager/sources/github.py
skill_manager/store/init.py
skill_manager/store/harness_support.py
skill_manager/store/shared_store.py
skill_manager/storage_paths.py
tests/support/marketplace_fixture.py
tests/unit/test_github_repo_metadata.py
tests/unit/test_marketplace_service.py
tests/unit/test_store.py
tests/unit/test_storage_paths.py

Validation

  • /Users/siruizhang/Desktop/ModeIOSkill/project_skills/python-test-env/scripts/python-test-env.sh all --repo /Users/siruizhang/Desktop/ModeIOSkill/.worktrees/skillmgr--new--legacy-cleanup
  • npm test
  • npm run typecheck
  • npm run build
  • ./.venv/bin/python scripts/build_release.py
  • ./.venv/bin/python scripts/validate_release_artifact.py --artifact .artifacts/release/skill-manager-v0.1.0-darwin-arm64.tar.gz --version 0.1.0
  • bash scripts/validate_npm_wrapper.sh .artifacts/release/skill-manager-v0.1.0-darwin-arm64.tar.gz

Reviewer: @SI-RUI-ZHANG

@SI-RUI-ZHANG SI-RUI-ZHANG merged commit 17a2d23 into main Apr 15, 2026
7 checks passed
@SI-RUI-ZHANG SI-RUI-ZHANG deleted the skillmgr-legacy-cleanup branch April 15, 2026 07:17
SI-RUI-ZHANG added a commit that referenced this pull request Apr 19, 2026
* Simplify legacy storage and marketplace cache schemas

* Tighten README user-facing configuration docs

* Fix storage path test portability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant